Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Cleanup UNIX Socket file #27886

Merged
merged 5 commits into from
Sep 16, 2021
Merged

server: Cleanup UNIX Socket file #27886

merged 5 commits into from
Sep 16, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Sep 8, 2021

What problem does this PR solve?

Issue Number: close #26058

Problem Summary: When tidb-server stops unexpectedly it might not be able to cleanup the UNIX socket file it was listening on. The result is that the server can't start again until the file is removed.

What is changed and how it works?

How it Works:

Getting the list of listening UNIX sockets is possible on Linux, but is not portable.
So instead this tries to os.Stat() the socket file and then:

  • Checks if this is a socket file
  • Checks if it can connect with net.Dial
  • Removes the file if it is a socket file and if it can't connect.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note 

On startup `tidb-server` removes unused socket files from previous instances

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Sep 8, 2021

/cc @mjonss

@ti-chi-bot ti-chi-bot requested a review from mjonss September 8, 2021 09:07
mjonss
mjonss approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice error handling!

@ti-chi-bot
Copy link
Member

@mjonss: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM, nice error handling!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@dveeden
Copy link
Contributor Author

dveeden commented Sep 14, 2021

/cc @lysu

@ti-chi-bot ti-chi-bot requested a review from lysu September 14, 2021 13:24
lysu
lysu approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2021
@lysu
Copy link
Contributor

lysu commented Sep 14, 2021

/cc @jackysp

@ti-chi-bot ti-chi-bot requested a review from jackysp September 14, 2021 13:30
morgo
morgo reviewed Sep 14, 2021
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
xhebox
xhebox reviewed Sep 15, 2021
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
@dveeden dveeden force-pushed the cleanup_unix_socket branch from 4d5f658 to 0efd8cc Compare September 15, 2021 14:28
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2021
@dveeden dveeden force-pushed the cleanup_unix_socket branch from 0efd8cc to c8ad815 Compare September 15, 2021 14:34
@dveeden dveeden force-pushed the cleanup_unix_socket branch from c8ad815 to b74605f Compare September 15, 2021 14:34
morgo
morgo reviewed Sep 15, 2021
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
@morgo morgo self-requested a review September 15, 2021 17:05
morgo
morgo approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets give @xhebox a moment to respond as well before merging.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@xhebox
Copy link
Contributor

xhebox commented Sep 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae01f84

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@ti-chi-bot
Copy link
Member

@dveeden: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 95ccea5 into pingcap:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox left review comments

@mjonss mjonss mjonss approved these changes

@lysu lysu lysu approved these changes

@morgo morgo morgo approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb using unix socket cannot restart if after SIGKILL
6 participants
@dveeden @ti-chi-bot @lysu @xhebox @morgo @mjonss